Empty patron search can lead to heavy DB query / client error
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Evergreen |
Fix Released
|
Undecided
|
Unassigned | ||
2.7 |
Fix Released
|
Undecided
|
Unassigned | ||
2.8 |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
Confirmed in Evergreen master (circa 2.8) and 2.5.
Clicking "Search" in the XUL client patron search with no search parameters results in a DB query which basically amounts to "Give me all patrons, sorted by name (etc.), limit to 50". On a large data set, this is a heavy query.
(The browser client does not have the same problem, because of how it compiles patron searches. Its empty queries are empty enough for the API to quickly exit).
In the end, it's not clear if this is a feature or a bug. Given the dubious value of such a query (and the "patron search is not a reporting tool" refrain), I'm inclined to consider this a bug.
Should we require the API to expect at least one filter?
To further guide staff toward sane queries, do we disable the patron Search button when no search values are present?
Changed in evergreen: | |
milestone: | 2.9-alpha → 2.9-beta |
Changed in evergreen: | |
assignee: | nobody → Jason Stephenson (jstephenson) |
Changed in evergreen: | |
milestone: | 2.9-beta → 2.9.0 |
Changed in evergreen: | |
status: | Fix Committed → Fix Released |
The "client error" I reference in the summary is the usual "A script on this page may be busy..." XUL client error.