Paging controls needed at the bottom of the web client patron search

[Kathy Lussier]

The ability to page on the web client patron search screen is a big win. However, users often don't realize they need to page until they've reached the bottom of the search results list. The paging controls are only available at the top of the page, requiring the user to scroll back up again to go to the next page.

Ideally, we would see the paging controls both at the top and bottom of the screen.

[Victoria Lewis (vlewis-q)]

In addition to 'Start', 'Previous Page', and 'Next Page' should I include 'Select Row Count', 'Select Page' and the drop-down with 'Configure Columns, Save Columns etc.' at the bottom of the page?
Thanks.
Victoria

[Mike Rylander (mrylander)]

I imagine you could just duplicate the whole button bar after the item rows, no?

[Bill Erickson (berick)]

That would be my suggestion as well. Just copy the whole button bar.

Beware variables in the template that affect whether a drop-down is open. For example:

is-open="gridColumnPickerIsOpen"

The secondary/copied drop-down would need a new variable, is-open="gridColumnPickerIsOpen2", or some such.

To reduce code duplication, I also suggest moving the button bar TT2 code out to its own .tt2 file, which is INCLUDE'd into into t_autogrid.tt2. That way we can INCLUDE it twice. With this, we'll need to pass a variable down with the INCLUDE statement to tell the button bar TT2 whether it's the top bar or the bottom bar, so it can modify local variables (see is-open example above) as needed.

[Victoria Lewis (vlewis-q)]

Added paging controls to the bottom of the web client patron search screen, Search for Copies by Barcode page, Record Bucket page and Copy Bucket page, all of which use the t_autogrid.tt2 file.

Moved the button bar TT2 code to button_bar.tt2 and INCLUDE'd it into
t_autogrid.tt2.

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/vlewis/lp1461739-add_paging_bottom_patron_search

[Galen Charlton (gmc)]

I've reviewed the patch, and it accomplishes the aim of having the controls be displayed at the top and bottom of egGrids. However, the actions drop-down menu disappeared, which is a showstopper. It looks like that when staff/share/button_bar.tt2 was broken out, it came from a version of t_autogrid.tt2 that predated commit 6ff052096c59. Could you rework the patch to be based on a more current copy of the master branch?

Also, I think staff/services/grid.js will need to be updated to account for the new *Top and *Bottom variables (e.g., gridColumnPickerIsOpenTop).

Also, a couple bookkeeping notes about the patch:

* Please include the bug number in the first line of the patch, e.g., "LP#1461739: added paging controls to the bottom of autogrids"
* Please include your signoff.

[Victoria Lewis (vlewis-q)]

    LP#1461739: Added paging controls to the bottom of autogrids

    This is a repatch of LP#1461739: Paging controls needed at the bottom
    of the web client patron search.

    The actions drop-down menu now appears on the Record Buckets,
    and Copy Buckets pages.

    staff/services/grid.js was updated to account for the new
    *Top and *Bottom variables (e.g., gridColumnPickerIsOpenTop).

    To test the fix for this bug
      [1] Under Cataloging choose Record Buckets.
      [2] Under Cataloging choose Copy Buckets.

    Signed-off-by: Victoria Lewis <email address hidden>

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/vlewis/lp1461739-add_paging_controls_bottom_patron_search

[Terran McCanna (tmccanna)]

Signing up to test this one on Bug Squashing Day...

[Galen Charlton (gmc)]

Hmm, the new patch lops off a lot of autogrid controls and does not apply as is. Could you rebase against master and verify that *only* the paging controls are touched in the next version?

[Terran McCanna (tmccanna)]

Considering this, I'll remove myself from the Bug Squashing Day list for testing this one unless it is rebased by then.

[Kyle Huckins (khuckins)]

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/collab/khuckins/lp1461739-paging-on-bottom

Patched up the original code submitted by Victoria. Bottom bar is aligned with the top bar, and has all expected features.

[Christine Burns (christine-burns)]

tested on https://mlnc3.noblenet.org/eg/staff/

Paging controls have been added to the bottom of the web client
- Patron Search screen
- Search for Copies by Barcode page
- Record Bucket page
- Copy Bucket page.
Bottom bar is aligned with the top bar, and has all expected features.

"I have tested this code and consent to signing off on it with my name, Christine Burns and my email address, <email address hidden>

[Christine Burns (christine-burns)]

Removing my sign off -> the bottom bar is now aligned with top bar and has all expected features but the bottom bar paging controls have been added to additional interfaces - some feel unnecessary (screen crowding).

I think bottom bar paging controls should be removed from these screens
Checkout
Items Out
Holds
Bills
Messages

I think bottom bar paging controls can be left on these screens
Search for Patrons
Search for Copies by Barcode page
Check In
Renew Items
Pending Patrons
Record In House Use
Holds Shelf
Capture Holds
Pull List for Hold Request
Record Buckets
Copy Buckets

[Kathy Lussier (klussier)]

Adding a note that the concern with the paging controls inside the patron account is that it is bumping against other elements on the page. I'm attaching a screenshot that demonstrates this crowding on the Items Out screen.

[Kyle Huckins (khuckins)]

Christine,

That's a good point, this is pretty all encompassing. I can see about flagging it so it will only display the bottom bar on specific interfaces.

Kathy,

I've amended my previous commit with a small fix that should resolve the dumping up of different elements.

[Bill Erickson (berick)]

Looks like there's still some discussion on this. And there's a 'needsrepatch' tag. Removing 'pullrequest' tag.