TPAC: coded values labels can come from wrong locale

Bug #1452352 reported by Galen Charlton on 2015-05-06
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Medium
Unassigned

Bug Description

The R/O object cache used to store various values for use by TPAC templates hangs on to the locale that was in effect the first time the it was initialized for a particular Apache backend process. This means that (for example) coded value map entries for the OPAC material format attributes can display en-US labels even when the user session is in (say) fr-CA.

This can be reproduced as follows:

[1] Enable both en-US and fr-CA. Make sure that there are some translations for record format coded values in place as well.
[2] Run Apache in single-process mode (e.g., ". /etc/apache2/envvars && apache2 -X")
[3] Visit a record details page in the en-US locale. Note the label associated with the record format.
[4] Change the locale to fr-CA. Note that the label is still the English version.

Evergreen master

Galen Charlton (gmc) wrote :

A patch is available in the user/gmcharlt/lp1452352_fix_locale_awareness_of_ro_objects_cached_by_tpac branch of the Evergreen working repository:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/gmcharlt/lp1452352_fix_locale_awareness_of_ro_objects_cached_by_tpac

Galen Charlton (gmc) wrote :

Rather, *two* patches are available on that branch.

Galen Charlton (gmc) wrote :

I've pushed a follow-up patch, so there are now three.

Galen Charlton (gmc) on 2015-05-07
tags: added: pullrequest tpac
Galen Charlton (gmc) on 2015-05-07
Changed in evergreen:
importance: Undecided → Medium
Bill Erickson (berick) on 2015-06-10
Changed in evergreen:
assignee: nobody → Bill Erickson (berick)
Bill Erickson (berick) on 2015-06-10
Changed in evergreen:
status: New → Confirmed
Bill Erickson (berick) wrote :

Bug and fix confirmed. This seems like a bug fix to me (i.e. back-portable), but the code is fairly tightly integrated with new feature code (bug #1452366 and bug #1449709). I'm guessing we just want to merge the entire set to master only?

Bill Erickson (berick) wrote :

Merged to master. Thanks.

Changed in evergreen:
assignee: Bill Erickson (berick) → nobody
status: Confirmed → Fix Committed
Bill Erickson (berick) on 2015-06-10
Changed in evergreen:
milestone: none → 2.9-alpha
Changed in evergreen:
milestone: 2.9-alpha → 2.9-beta
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers