'NO COPIES' output displayed in staff client, when non-visible copies exist

[Liam Whalen]

Evergreen 2.8
OpenSRF 2.4
PostgreSQL 9.1
Ubuntu 14.04

When viewing records with copies that are solely non-visible in the Staff Client, a 'NO COPIES' message is displayed. This is confusing for staff, who can see, by the copy count, that copies do exist.

[Liam Whalen (whalen-ld)]

Here is my working branch with a fix for this bug:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/ldw/LP1441714_No_Copies_Message

[Erica Rohlfs (erohlfs)]

I could not recreate a "No Copies" instance. I could recreate a "0 copies at [insert Consortium]" message within the staff client for version 2.8.4. Within version 2.9.0, the behavior is different. Attached is a screen image of the different views within a test database. I see the same behavior in Master for the 3/4/16 bug day. I will go ahead and sign-off on this one, but I am unsure if I reproduced the same bug as described or if this fix was already included in version 2.9.

I have tested this code and consent to signing off on it with my name, [Erica Rohlfs] and email address, [<email address hidden>].

[Kathy Lussier (klussier)]

Thank you for the feedback Erica! Until we can confirm that the original problem continues to exist in 2.9+, I'm going to change the status of this one to Incomplete, primarily because I don't want the code being merged if it turns out it wasn't needed. I'll assign myself to this one to investigate further so that it doesn't get lost in the shuffle.

[Kathy Lussier (klussier)]

I finally had a chance to take a look at this bug. You can replicate the bug by doing the following in any of the supported Evergreen releases:

- Add a record to the database with one copy that is set to OPAC visible False.
- Do a search for the record in the staff client. The record will appropriately appear in the search results list with a copy count that says 1 of 1 copy available.
- Click the Show More Details button. No holdings information will be listed for the copy. A staff user would expect to see the holdings information for those copies that are not visible to the public.

I tested Liam's patch, and it successfully displays this holdings information for copies that have OPAC visible set to False and for copies living in a copy location that is nonvisible in the OPAC.

However, I did encounter a problem for copies with a circulation library that is nonvisible in the OPAC. Those copies did not appear along with the other holdings on the search results page.

Looking at the code, it appears as if the intent was to make those copies display. Nothing jumped out at me as causing the display to behave otherwise.

Setting this bug back to confirmed with a needsrepatch tag to see if that last issue can be resolved.

[Terran McCanna (tmccanna)]

I tested this with the Angular staff catalog and it is no longer a problem. Marking Won't Fix.