Patron search parameters not retained

[Sally Fortin]

In the web client, if you search for a patron using the expanded patron search fields, open a record, and then click "Patron Search" to return to the search form, the client should retain the search parameters. All of the search parameters are retained with two exceptions. The OU that was selected is not saved. If you click patron search, it always bounces back to consortium. Also, the Profile Group dropdown does not work, so you can neither select nor retain a preference.

[Mike Rylander (mrylander)]

As of http://git.evergreen-ils.org/?p=working/Evergreen.git;a=commitdiff;h=432f316013370eafb04ae87ae5ed49c740b32ec4 the Profile Group dropdown does work, but its selected value is not retained, as with the OU dropdown.

[Blake GH (bmagic)]

I can confirm this bug in 2.8.2

[Victoria Lewis (vlewis-q)]

 lp#1436987: Patron search parameters not retained

    This patch ensures that OU and Profile Group parameters are retained.

    To test the fix for this bug
       [1] Search for a patron using the expanded patron search fields.
       [2] Open a record and click "Patron Search" to return to the
           search form.

    Signed-off-by: Victoria Lewis <email address hidden>

        modified: Open-ILS/src/templates/staff/circ/patron/t_search.tt2
        modified: Open-ILS/web/js/ui/default/staff/circ/patron/app.js

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/vlewis/lp1436987-patron-search-parameters-not-retained

[Christine Burns (christine-burns)]

I have tested this code and consent to signing off on it with my name, [Christine Burns] and email address, [<email address hidden>]

tested on Sandbox provided courtesy of MOBIUS

[1] Search for a patron using the expanded patron search fields.
[2] Open a record and click "Patron Search" to return to the search form.
--> selected values for OU & Profile group have been retained.

Additionally You can check out an item or place a hold and then click "Patron Search" to return to the search form and the selected values for OU & Profile group have been retained.

[Galen Charlton (gmc)]

Unfortunately, the patch does not fully work: when you go back to the search form, clicking search again does not retrieve the original results.

A variant patch that fixes both the display and causes the search to be be (re)performed correctly can be found at the tip of the user/gmcharlt/lp1436987_patron_search_params branch in the working/Evergreen repository:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/gmcharlt/lp1436987_patron_search_params

[Bill Erickson (berick)]

Tested Galen's patch with success. Sign-off pushed here in case anyone else wants to review:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1436987-webstaff-patron-search-propagate-signoff

[Mike Rylander (mrylander)]

This is now in master, for 2.11. Thanks, Galen!