Patron search parameters not retained

Bug #1436987 reported by Sally Fortin
18
This bug affects 4 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Medium
Unassigned

Bug Description

In the web client, if you search for a patron using the expanded patron search fields, open a record, and then click "Patron Search" to return to the search form, the client should retain the search parameters. All of the search parameters are retained with two exceptions. The OU that was selected is not saved. If you click patron search, it always bounces back to consortium. Also, the Profile Group dropdown does not work, so you can neither select nor retain a preference.

Revision history for this message
Mike Rylander (mrylander) wrote :

As of http://git.evergreen-ils.org/?p=working/Evergreen.git;a=commitdiff;h=432f316013370eafb04ae87ae5ed49c740b32ec4 the Profile Group dropdown does work, but its selected value is not retained, as with the OU dropdown.

tags: added: webstaffclient
Revision history for this message
Blake GH (bmagic) wrote :

I can confirm this bug in 2.8.2

Kathy Lussier (klussier)
Changed in evergreen:
status: New → Confirmed
Changed in evergreen:
assignee: nobody → Victoria Lewis (vlewis-q)
Revision history for this message
Victoria Lewis (vlewis-q) wrote :

 lp#1436987: Patron search parameters not retained

    This patch ensures that OU and Profile Group parameters are retained.

    To test the fix for this bug
       [1] Search for a patron using the expanded patron search fields.
       [2] Open a record and click "Patron Search" to return to the
           search form.

    Signed-off-by: Victoria Lewis <email address hidden>

        modified: Open-ILS/src/templates/staff/circ/patron/t_search.tt2
        modified: Open-ILS/web/js/ui/default/staff/circ/patron/app.js

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/vlewis/lp1436987-patron-search-parameters-not-retained

tags: added: pullrequest
Changed in evergreen:
assignee: Victoria Lewis (vlewis-q) → nobody
Changed in evergreen:
assignee: nobody → Christine Burns (christine-burns)
Revision history for this message
Christine Burns (christine-burns) wrote :

I have tested this code and consent to signing off on it with my name, [Christine Burns] and email address, [<email address hidden>]

tested on Sandbox provided courtesy of MOBIUS

[1] Search for a patron using the expanded patron search fields.
[2] Open a record and click "Patron Search" to return to the search form.
--> selected values for OU & Profile group have been retained.

Additionally You can check out an item or place a hold and then click "Patron Search" to return to the search form and the selected values for OU & Profile group have been retained.

Changed in evergreen:
assignee: Christine Burns (christine-burns) → nobody
tags: added: signedoff
Galen Charlton (gmc)
Changed in evergreen:
importance: Undecided → Medium
milestone: none → 2.10-rc
Revision history for this message
Galen Charlton (gmc) wrote :

Unfortunately, the patch does not fully work: when you go back to the search form, clicking search again does not retrieve the original results.

A variant patch that fixes both the display and causes the search to be be (re)performed correctly can be found at the tip of the user/gmcharlt/lp1436987_patron_search_params branch in the working/Evergreen repository:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/gmcharlt/lp1436987_patron_search_params

tags: removed: signedoff
Galen Charlton (gmc)
Changed in evergreen:
milestone: 2.10-rc → none
Kathy Lussier (klussier)
tags: added: needsrepatch
removed: pullrequest
Revision history for this message
Bill Erickson (berick) wrote :
tags: added: pullrequest
removed: needsrepatch
Changed in evergreen:
milestone: none → 2.next
Revision history for this message
Mike Rylander (mrylander) wrote :

This is now in master, for 2.11. Thanks, Galen!

Changed in evergreen:
status: Confirmed → Fix Committed
Changed in evergreen:
milestone: 2.next → 2.11-rc
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.