Total Circulations in Patron Bills

Bug #1436980 reported by Sally Fortin
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Evergreen
Undecided
Unassigned

Bug Description

In the web client, retrieve a patron's record. Select a bill. Click Actions -> Full Details. The item summary area shows "Total Circulations: TODO". This area needs to be completed.

Sally Fortin (sfortin)
tags: added: webstaffclient
Changed in evergreen:
assignee: nobody → Victoria Lewis (vlewis-q)
Revision history for this message
Victoria Lewis (vlewis-q) wrote :

 I created a bill on a patron's record through the Bill Patron modal.
When I select the bill in the patron's record and click on Actions->Full Details I don't get an item summary.
Any suggestions would be welcome.

Revision history for this message
Thomas Berezansky (tsbere) wrote :

If you created a bill *not associated with an existing checkout* then there is no item. You have, at that point, created a "Grocery" billing, unassociated with any circulations. As there is no circulation there is also no item.

Revision history for this message
Victoria Lewis (vlewis-q) wrote :

The item summary with "Total Circulations: TODO" shows when I retrieve a patron's record. Select History. Select a bill. Click Actions -> Full Details. The original bug description doesn't include History. Do I have the correct workflow?

Revision history for this message
Victoria Lewis (vlewis-q) wrote :
Changed in evergreen:
assignee: Victoria Lewis (vlewis-q) → nobody
tags: added: pullrequest
Revision history for this message
Mike Rylander (mrylander) wrote :

Victoria, this looks good. I wonder if we should initialize $scope.total_circs to 0 before using pcrud to look up the real value, as that might return no rows.

Thoughts?

Revision history for this message
Mike Rylander (mrylander) wrote :

Victoria,

I have picked your commit and added one to default the circ count to 0.

Thanks!

Changed in evergreen:
status: New → Fix Committed
Changed in evergreen:
status: Fix Committed → In Progress
milestone: none → 2.next
Revision history for this message
Ben Shum (bshum) wrote :

Mike pushed this on 9/16 before 2.9.0, so resetting milestone to 2.9.0 and marking fix committed.

Changed in evergreen:
status: In Progress → Fix Committed
milestone: 2.next → 2.9.0
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers