Add class attribute to e-resource links in TPAC

Bug #1433328 reported by Jeff Davis
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fix Released

Bug Description

In the TPAC, links to electronic resources are not directly, uniquely identifiable in the DOM. You can specify these links indirectly, with something like '.result_table_title_cell > td > a' in search results or '.rdetail_uri > a' on the record details page, but this is fragile and a bit cumbersome. Adding a unique class attribute directly to the link elements would make things easier for services built on top of the TPAC, such as Overdrive API integration or JS-based analytics for e-resources.

Revision history for this message
Jeff Davis (jdavis-sitka) wrote :

Commit pushed to working branch user/jeffdavis/lp1433328_uri_link_class:;a=commitdiff;h=28d2e83

tags: added: pullrequest tpac
Changed in evergreen:
assignee: nobody → Josh Stompro (u-launchpad-stompro-org)
Revision history for this message
Josh Stompro (u-launchpad-stompro-org) wrote :

Works as described, electronic resource links now have a class="uri_link" added to them. The reasoning behind this also makes sense to me.

I have tested this code and consent to signing off on it with my
name, Josh Stompro and email address, <email address hidden>.

tags: added: signedoff
Changed in evergreen:
status: New → Confirmed
assignee: Josh Stompro (u-launchpad-stompro-org) → nobody
Changed in evergreen:
milestone: none → 2.9-alpha
Changed in evergreen:
milestone: 2.9-alpha → 2.9-beta
Revision history for this message
Ben Shum (bshum) wrote :

I added a release note for this under OPAC and pushed it to master.

Thanks Jeff and Josh!

Changed in evergreen:
status: Confirmed → Fix Committed
importance: Undecided → Wishlist
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.