Add message process duration to logs

Bug #1425135 reported by Bill Erickson
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
SIPServer
Fix Released
Wishlist
Unassigned

Bug Description

In cases where local syslog writes with 1-second granularity, it would be good to log SIP message processing duration with millisecond granularity for improved diagnostics. This is especially useful for diagnosing SIP speed issues with automated materials handling, where small changes in speed can have a big impact.

Wee patch en route.

Tags: pullrequest
Revision history for this message
Bill Erickson (berick) wrote :
tags: added: pullrequest
Revision history for this message
Galen Charlton (gmc) wrote :

Looks OK, but I've got a couple quibbles:

- Does the log level need to be info rather than debug?
- Does the entire request, which may contain personally identifying information, need to be included in the log message? Note that I'm less concerned on this point if the log level is changed to debug.

Revision history for this message
Bill Erickson (berick) wrote :

Thanks, Galen. Agreed DEBUG makes more sense, but beware there are other INFO lines logging the full message.

Revision history for this message
Bill Erickson (berick) wrote :

Force-pushed change to DEBUG for the new log line. I can push a follow-up patch to change the others if we're agreed on that.

Revision history for this message
Galen Charlton (gmc) wrote :

Thanks, Bill. I've pushed the revised patch to master. I suggest opening a new bug for adjusting the existing log messages that include the full request.

Changed in sipserver:
status: New → Fix Committed
importance: Undecided → Wishlist
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.