Comment 12 for bug 1424815

Revision history for this message
Remington Steed (rjs7) wrote :

I tested this branch, and it worked, but after reading through the code I decided to try cleaning it up some. After the cleanup, it works the same as advertised. Here's my sign-off branch, with one extra commit on top:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/rsteed/lp1424815_long_fields_accordion_jquery-approach

And from the commit message:
-----------

This commit attempts to cleanup and simplify the "Read more" catalog
feature by making the following changes:

  - Simplify perl util function
    - Remove extra blank lines
    - Remove first IF branch, since rindex already covers this case
    - Remove "rest" from return value, since Kathy's changed stopped
      using it
    - Add logic to address the FIXME comment
    - Add a few code comments

  - Simplify template
    - Only split a string if feature is turned on in config settings
    - Allow, but don't require, "trunc_length" on every marc note field
    - Add a few code comments