a couple more queries should check for deleted copy locations

[Galen Charlton]

The patch for bug 1210541 introduces a new deleted flag column in the asset.copy_location table. That patch adds checks on that flag as needed, but there are a couple spots left where that check should be added:

OpenILS::Application::AppUtils::basic_opac_copy_query()

Even though other TPAC code has the effect of filtering out any items whose copy location is marked as deleted, the query in this routine should also filter out such items for the sake of consistency.

OpenILS::Application::Circ::Holds::_check_title_hold_is_possible()

As another bit of defensive coding, items whose copy location is deleted should be excluded.

One thing to note is that while there *shouldn't* be undeleted copies attached to deleted copy locations, there isn't at present a DB constraint in place that enforces that. Consequently, adding filters on acpl.deleted in all the relevant queries would add some defensive programming.

Evergreen master

[Galen Charlton (gmc)]

A patch is available at the tip of the user/gmcharlt/lp1423813_more_acpl_deleted_filters branch in the working/Evergreen repository:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/gmcharlt/lp1423813_more_acpl_deleted_filters

[Ben Shum (bshum)]

Pushed to master for 2.8 beta.