TPAC: Holds history paging is broken

[Bob Wicksall]

Evergreen 2.7.3 (And probably older)

Holds history paging does not work. All holds are displayed regardless of paging. Tested with a history of 30+ holds.

It looks like paging was enhanced with this:

http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=97221b394a50415d9ac52efb9304b5b96d0ae581

And then broken with this:

http://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=a2a6225fdc1d0e389c7b39aeeca9229d71e5bbf8

Quote from above commit:

"The code in this commit moves the handling of the offset and limit to cases
where the input hold_ids is undefined, as this is, I think the intended
behavior. Typically when hold_ids is passed to the fetch_user_holds function
in EGCatLoader::Account, you want to retrieve those holds regardless of
the offset and limit values."

[Terran McCanna (tmccanna)]

Note that this is still broken in the Bootstrap OPAC (3.6.1) as well.

[Terran McCanna (tmccanna)]

Still an issue in 3.8.

[Garry Collum (gcollum)]

A proposed fix for both the TPac and the Bootstrap opac is at https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/gcollum/lp1422927-Opac-hold-history-pagination

[Garry Collum (gcollum)]

An easy way to test in concerto without placing holds on 15 or more items is to turn on holds history for a patron, place 3 or more holds, view the holds history, and then add ;limit=2;offset=0 to the end of the url to force pagination.

[Terran McCanna (tmccanna)]

Works for me! My sign off is at: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mccanna/lp1422927-Opac-hold-history-pagination-signoff

[Michele Morgan (mmorgan)]

Works great to fix this long standing bug. Pushed to master, rel_3_10, rel_3_9 and rel_3_8.

Thanks Garry and Terran!