outdated version of authority.normalize_heading can be present in certain upgraded databases

Bug #1415572 reported by Galen Charlton
16
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Evergreen
High
Unassigned
2.6
High
Unassigned
2.7
High
Unassigned

Bug Description

The schema upgrade script 0848.function.authority-sf-file-order-again.sql, which was backported through rel_2_3, can in rel_2_5, rel_2_6, and rel_2_7 effectively rollback a change in that function introduced by 0837.schema.browse-auth-linking.plus-joiner.sql.

Consequently, if applying updates in sequence, if 0837 is applied first, then 0848, a slightly broken version of normalize_heading() will be in place. This will manifest itself by the heading and simple_heading columns in authority.record_entry having "NOHEADING" values regardless of the control set:

-[ RECORD 1 ]--+---------------------------------------------
heading | NOHEADING_a ff0ed9fcd13e8944d9a718650840787a
simple_heading | NOHEADING_a ff0ed9fcd13e8944d9a718650840787a

Evergreen master
Evergreen 2.7.x
Evergreen 2.6.x

Galen Charlton (gmc)
Changed in evergreen:
milestone: none → 2.8-beta
Revision history for this message
Galen Charlton (gmc) wrote :

A patch to fix this is available in the user/gmcharlt/lp1415572_use_current_normalize_heading branch in the working/Evergreen repository:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/gmcharlt/lp1415572_use_current_normalize_heading

I can confirm that as of master commit 609db84, this patch will apply correctly to master, rel_2_7, and rel_2_6. It should NOT be applied without changed if another commit that alters authority.normalize_heading makes it in first.

Changed in evergreen:
importance: Undecided → High
tags: added: pullrequest
Revision history for this message
Chris Sharp (chrissharp123) wrote :
Revision history for this message
Ben Shum (bshum) wrote :

Pushed to master, rel_2_7 and rel_2_6.

Changed in evergreen:
status: New → Fix Committed
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers