Merge parts functionality fails to preserve copy_part mapping

[Michele Morgan]

The Merge Monograph Parts functionality new in 2.7 does not preserve the copy/part mapping for the deleted part.

Here's the original launchpad bug:

https://bugs.launchpad.net/evergreen/+bug/1099979

and the commit:

http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=8f4d3efb029f109d3dc7dc69cf458c2834c725d6

When selected parts are merged in the Manage Parts interface in the client, the user chooses a "prevailing item", which is the part to be preserved. The remaining selected parts are deleted when the user clicks to choose the prevailing item.

Any copy that was mapped to the deleted parts, loses its part mapping rather than having the mapping updated to the prevailing part.

It looks like a row is being deleted from asset.copy_part_map rather than being updated with the prevailing part's id.

Updating this mapping is essential to using this functionality.

[Mary Llewellyn (mllewell)]

Yes, we've seen this happen, too. I've been pointing the item to the desired part prior to merging the parts, just to avoid running into the deletion.

[Ben Shum (bshum)]

Marking bug as confirmed.

[Galen Charlton (gmc)]

A patch is available at the tip of the user/gmcharlt/lp1406786_move_copy_maps_during_parts_merge branch in the working/Evergreen repository:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/gmcharlt/lp1406786_move_copy_maps_during_parts_merge

[Dan Pearl (dpearl)]

I had a fix for this, but Galen's change is smaller. Thanks, Galen!

[Galen Charlton (gmc)]

Yeah, Kathy mentioned that we were poking around the same area of code. Mind testing and signing off on my patch, Dan?

[Dan Wells (dbw2)]

Looks good, works great. Pushed to master and all active versions. Thanks, Galen!