Mobile device navigation issue in OPAC Shelf Browser

Bug #1406350 reported by Terran McCanna
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Medium
Unassigned
2.6
Fix Released
Undecided
Unassigned
2.7
Fix Released
Undecided
Unassigned

Bug Description

From a mobile device - if you do an advanced numeric search by call number, the Next/Prev page links disappear if the display is under a certain width, making it impossible to navigate.

Tested on several types of smartphones as well as in a web browser by narrowing the size or using Firefox's Responsive Design View.

Same behavior in both Evergreen 2.5 & 2.7.

Revision history for this message
Ben Shum (bshum) wrote :

This is also broken in the bib record's shelf browser when looking at the individual bib level.

Marking confirmed.

Changed in evergreen:
status: New → Confirmed
importance: Undecided → Medium
tags: added: opac responsive tpac
Revision history for this message
Adam Bowling (abowling) wrote :

I have posted a fix for this on the shelf browser template "cnbrowse.tt2". The only solution that works consistently seems to be to remove the "THEAD" element from the browser table.

user/abowling/lp1406350_mobile_browser_navigation_fix

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=commit;h=e8e9e64b774b8baa707e40ce3fa26c0a96c85bb3

tags: added: pullrequest
Yamil (ysuarez)
Changed in evergreen:
assignee: nobody → Yamil (ysuarez)
Revision history for this message
Yamil (ysuarez) wrote :

I have tested this code and consent to signing off on it with my name, Yamil Suarez aka yboston and email address, <email address hidden>

NOTE: It looks like that the commit can cause a merge conflict with master. I noticed this because I was going to signoff this commit, but I need to resolve the conflict. I rather give someone a chance to handle the conflict resolution and committing faster than I could.

tags: added: signedoff
Changed in evergreen:
assignee: Yamil (ysuarez) → nobody
Revision history for this message
Kathy Lussier (klussier) wrote :

I've resolved the conflict. Working branch is at:
http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/kmlussier/lp1406350_mobile_browser_navigation_fix

Yamil, I'll load this new branch on to a Sandbox if you want to take another look at it.

Revision history for this message
Yamil (ysuarez) wrote :
Revision history for this message
Ben Shum (bshum) wrote :

Pushed Yamil's signoff on Adam's work to master, rel_2_7 and rel_2_6. Thanks guys!

Changed in evergreen:
milestone: none → 2.8-beta
status: Confirmed → Fix Committed
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.