Items set to OPAC invisible not retrieved when group formats and editions used in staff client

[Elaine Hardy]

In ver 2.7.1, a title either with all copies set to be OPAC invisible or with the search library's item set to OPAC invisible will not retrieve when the search is grouped by formats and editions. While this is behavior preferred for the public facing OPAC, we would prefer to see all records in a staff client search.

[Adam Bowling (abowling)]

Add patch that allows opac_visible = 'f' items to be seen in the staff client, but remain appropriately set in the TPAC.

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=commit;h=0fbe067195df5b6b4df791aba5d2a732d7c3021c

user/abowling/lp1403913_items_visible_staff_client

[Mike Rylander (mrylander)]

Thanks, Adam. Out of curiosity, is there a reason not to just reference ctx.is_staff directly?

[Blake GH (bmagic)]

I was setting this bug up for bug squashing day and found an error. I fixed the error and committed it here:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=commit;h=5ff7777fe15f3e9e6667660d5d365ffc3af1c904

It was a single equal sign, needed to be double.

[Jennifer Pringle (jpringle-u)]

 I have tested this code and consent to signing off on it with my name, Jennifer Pringle and my email address, <email address hidden>.

[Ben Shum (bshum)]

Hmm, while this code was tested and there's signoffs from folks, I'm going to go with Mike's question in comment #2 above about use of the ctx.is_staff variable instead of adding the need for additional variable values.

Going to tag this temporarily with "needsrepatch" to indicate that some more work is required on this bug before we can merge.

[Kathy Lussier (klussier)]

Removing myself as an assignee. With the new metarecord and visibility work that has been added to Evergreen since 2.7, I think it's worth re-testing this bug to see if it's still an issue.

[Terran McCanna (tmccanna)]

This does not appear to be a problem in the Angular staff catalog.