UPC search in misc_util.tt2 is too broad

[Dan Scott]

* Evergreen master (all the way back to the beginning of TPAC time)

misc_util.tt2 currently searches for UPC codes like so:

        args.upcs = [];
        FOR upc IN xml.findnodes('//*[@tag="024"]/*[@code="a"]');
            args.upcs.push(upc.textContent);
        END;
        args.upc = args.upcs.0; # use first UPC as the default

However, the 024 field can actually be used for many, many different other standard identifiers, as documented at http://www.loc.gov/marc/bibliographic/bd024.html

The search for UPCs should look for either a first indicator of "1" or a subfield 2 with a value of "upc" (per http://www.loc.gov/standards/sourcelist/standard-identifier.html) to avoid false positives.

[Dan Scott (denials)]

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dbs/lp1402905_stricter_upc is a simple attempt to address this issue. Still needs testing before I'm going to tag this as a pull request.

[Dan Scott (denials)]

Tested and I'm happy with it. Added a pullrequest tag.

[Ben Shum (bshum)]

Seems like a logical fix to me. Pushed to master and backported to rel_2_7 and rel_2_6.