856 URLs in search results often display full URL as link text rather than notes

Bug #1401286 reported by Dan Scott
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fix Released
Fix Released

Bug Description

* Evergreen master back through 2.4 or so

misc_util.tt2 gathers args.online_res for display in the record summary and args.uris for the search results, resulting in different behaviours in each (sigh).

Right now I'm trying to solve the problem of a record with an 856 like:

856 4 0 ‡zAvailable online ‡uhttp://publications.gc.ca/collections/collection_2013/bdp-lop/bp/2003-41-eng.pdf ‡9LUSYS

showing up in search results with an HTML display like:

<a href="http://publications.gc.ca/collections/collection_2013/bdp-lop/bp/2013-3-eng.pdf">http://publications.gc.ca/collections/collection_2013/bdp-lop/bp/2013-3-eng.pdf</a> - Available online

rather than the much cleaner:

<a href="http://publications.gc.ca/collections/collection_2013/bdp-lop/bp/2013-3-eng.pdf">Available online</a>

My simplistic approach is to check to see if the link text == the href, and if so, and we have a note to display, to use the note as the text of the link instead.

In the long run, it would be nice to avoid having to deal with different display logic for the search results vs. the record summary.

Tags: pullrequest
Revision history for this message
Dan Scott (denials) wrote :
tags: added: pullrequest
Changed in evergreen:
milestone: none → 2.7.2
Revision history for this message
Ben Shum (bshum) wrote :

Fix pushed to master, rel_2_7 and rel_2_6.

Changed in evergreen:
status: New → Fix Committed
Galen Charlton (gmc)
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.