Organization Unit Main Email Address Should Accept the Hyphen Character

Bug #1400801 reported by Erica Rohlfs
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Undecided
Unassigned
2.8
Fix Released
Undecided
Unassigned

Bug Description

Evergreen version 2.6

It is quite common for organization email addresses to include hyphens. Currently, entering the hyphen character into the Org Unit’s Main Email Address results in a “The value entered is not valid” error. The hyphen character should be an accepted character in this field.

Tags: pullrequest
Revision history for this message
Michael Tate (mtate) wrote :

I would also recommend adding the plus sign "+", as this is used by many mail systems to "tag" email addresses.

Revision history for this message
Josh Stompro (u-launchpad-stompro-org) wrote :

I can confirm that I see the same behavior, It looks like a simple fix to adjust the regex in org_unit.html. I'll try and work on this during bug squashing day.

Josh

Changed in evergreen:
status: New → Confirmed
assignee: nobody → Josh Stompro (u-launchpad-stompro-org)
Revision history for this message
Josh Stompro (u-launchpad-stompro-org) wrote :

user/stompro/lp1400801_gui_org_unit_email_regex

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/stompro/lp1400801_gui_org_unit_email_regex

 Grabbed the example of a simplified RFC 5322 email regex from
 http://www.regular-expressions.info/email.html and lightly modified it
 for case sensitivity and removed the "&" character from the localpart allowed
 characters, which causes a 500 server error for some reason.

 This matches many more of the valid localpart special characters, such as "+" and "-".

Please test it out and let me know if you notice any problems. I think using "&" in email addresses is sufficiently rare to just let that go for now.

Josh

tags: added: pullrequest
Changed in evergreen:
assignee: Josh Stompro (u-launchpad-stompro-org) → nobody
Revision history for this message
Ben Shum (bshum) wrote :

Picked to master, and backported to rel_2_9 and rel_2_8.

Changed in evergreen:
milestone: none → 2.9.1
status: Confirmed → Fix Committed
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.