Extraneous </div> breaks RDFa/schema.org when openurl resolver is enabled

Bug #1400100 reported by Dan Scott
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Undecided
Unassigned
2.6
Fix Released
Undecided
Unassigned

Bug Description

* Evergreen master, 2.7, probably earlier

When the OpenURL resolver is enabled, the record summary.tt2 page always inserts a </div>, whether or not there actually are any OpenURL results to point at (which is the condition that triggers the opening <div>).

This has the effect of resulting in the generated RDFa not including anything below the OpenURL section, effectvely preventing the schema.org/Offer types from being associated with the record. Which is not good.

Tags: pullrequest
Revision history for this message
Dan Scott (denials) wrote :
tags: added: pullrequest
Changed in evergreen:
milestone: none → 2.7.2
Revision history for this message
Ben Shum (bshum) wrote :

Looks simple enough. Pushed to master, rel_2_7 and rel_2_6.

Thanks Dan!

Changed in evergreen:
status: New → Fix Committed
Galen Charlton (gmc)
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.