Selfcheck "Print List" for Holds view does not work

Bug #1370694 reported by Michele Morgan on 2014-09-17
14
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Evergreen
Medium
Unassigned
2.8
Medium
Unassigned
2.9
Medium
Unassigned

Bug Description

Evergreen 2.6.2

Using the Simple Selfcheck interface at:

https://<hostname>/eg/circ/selfcheck/main

The list of the patron's holds does not print. Checkout receipts and lists of items out print successfully, first popping up a preview of the receipt, then a printer dialog box. Clicking the "Print List" while viewing holds, however, does nothing but produce a javascript error:

TypeError: this.holds is undefined selfcheck.js:1355

The file referenced is:

/openils/var/web/js/ui/default/circ/selfcheck/selfcheck.js

Garry Collum (gcollum) on 2014-09-22
Changed in evergreen:
status: New → Confirmed
Kathy Lussier (klussier) on 2014-12-12
Changed in evergreen:
importance: Undecided → Medium
tags: added: selfcheck
Terran McCanna (tmccanna) wrote :

I got this working in our local implementation. I'll put together a fix and submit it for review.

Terran

Changed in evergreen:
assignee: nobody → Terran McCanna (tmccanna)
Terran McCanna (tmccanna) wrote :

I've submitted a proposed fix for this at:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=commit;h=9a97b90dfd1f5d2f1d806b0bcc2b0612d19fda86

After fixing the javascript problem that was preventing printing from happening at all, I discovered that the preferred sorting order (with the holds that are ready to be picked up at top) was different from the order in which the template printed the titles, which ended up causing data mismatches between the titles and the pickup libraries/statuses. So, I made some additional changes to pass all of the information from the javascript into the template rather than trying to match it up on the template side.

To test, the selfcheck.js will need to be put in place and the Self-Checkout Holds Receipt action trigger will need to be updated. I've included an update script, as well as an update to the seed data.

This is my first attempt at including database content updates, so I hope that I did them correctly! This is also my first attempt at including release notes. If anyone sees errors in my work, please let me know.

Changed in evergreen:
assignee: Terran McCanna (tmccanna) → nobody
tags: added: pullrequest
Jennifer Pringle (jpringle-u) wrote :

I have tested this code and consent to signing off on it with my name, Jennifer Pringle and email address, <email address hidden>.

tags: added: signedoff
Galen Charlton (gmc) on 2016-03-07
Changed in evergreen:
milestone: none → 2.10-rc
Galen Charlton (gmc) wrote :

Pushed all the way to rel_2_8. Thanks, Terran!

Changed in evergreen:
status: Confirmed → Fix Committed
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers