No Permission in IDL to delete BRE via PCRUD

Bug #1369128 reported by Jason Stephenson on 2014-09-13
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Wishlist
Unassigned

Bug Description

Evergreen: Master as of 2014-09-04
OpenSRF: Same
PostgreSQL: Irrelevant

I'm messing with pcrud calls and discovered that you cannot delete biblio.record_entry entries via pcrud because no delete permission is set.

The lack of the permission in the IDL leads to "Method [open-ils.pcrud.delete.bre] not found for service open-ils.pcrud."

Adding the DELETE_RECORD permission as the delete permission for BRE in the IDL works.

I want this so I can delete copies, call numbers, and bres neatly in a pcrud transaction.

I know there are other ways to accomplish what I am trying to achieve, but this seems like a no-brainer since it is a one-line addition to the IDL.

I'd also really like to see this in 2.7 as something I am working on depends on it at the moment.

I hit submit before I added that I would post a branch after I have something to eat.

description: updated
summary: - Impossible to delete BRE via PCRUD
+ No Permission in IDL to delete BRE via PCRUD
Jason Stephenson (jstephenson) wrote :
tags: added: pullrequest
Changed in evergreen:
importance: Undecided → Wishlist
Bill Erickson (berick) wrote :

PCRUD delete on "bre" was never added, because the existing API does more than delete the bib. It protects against deleting bibs w/ active call numbers, updates the MARC (leader/05), cancels holds, and queues hold notifications. I'm not against adding the PCRUD entry, because it might be useful in some context, but I'd prefer it be accompanied by a "use at own risk" warning in the IDL that basically says to use the API instead.

Jason Stephenson (jstephenson) wrote :

A warning works for me.

Jason Stephenson (jstephenson) wrote :

A warning was added, a commit amended, the branch rebased on master to pickup latest doc changes, and force pushed.

Jason Stephenson (jstephenson) wrote :

Altered the warning a bit, commit amended, branch rebased, and force pushed.

Ben Shum (bshum) wrote :

Pushed final version to master. Thanks Jason and Bill.

Changed in evergreen:
status: New → Fix Committed
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers