Suppress Hold Transit use elicits client error

[Dan Pearl]

EG 2.5+

 We have a branch BR1, and below it, a sub-library SL1. We have configured the Suppress Holds Transit Group for BR1 to have a Context of BR1 and Value of 1, and the Suppress Holds Transit Group for SL1 to have a Context of SL1 and Value of 1.

I placed a hold on a title with Pickup Lib SL1, and from a BR1 staff client we check-in a copy under that title.

Error:
> Network or server failure. Please check your Internet connection to
> 10.250.10.112 and choose Retry Network. If you need to enter Offline
> Mode, choose Ignore Errors in this and subsequent dialogs. If you
> believe this error is due to a bug in Evergreen and not network
> problems, please contact your help desk or friendly Evergreen
> administrators, and give them this information:
> method=open-ils.circ.checkin
> params=["231939de6855dcc92d72fc01f0e5152e",{"barcode":"CONC41000573"}]
> THROWN:
> {"payload":[],"debug":"osrfMethodException : *** Call to [open-
> ils.circ.checkin] failed for session
> [1400593342.536597.140059334232077], thread trace [1]:\nCan't call
> method \"pickup_lib\" on an undefined value at
> /usr/local/share/perl/5.10.1/OpenILS/Application/Circ/Circulate.pm
> line 3035.\n\n","status":500}
> STATUS:
>

[Dan Pearl (dpearl)]

With some guidance by Tom Berezansky (the original author of the code), here is the fix

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dpearl/supp_trans

[Galen Charlton (gmc)]

Pushed to master, rel_2_6, and rel_2_5. Thanks, Dan!