Comment 4 for bug 1321017

Revision history for this message
Mike Rylander (mrylander) wrote :

Thanks, Galen.

The trimming of the parameter list was (hopefully, obviously ;) ) unintentional. I'll push a squash-able commit bringing those back.

As to whether we might want to filter (or, as you put it, pass anything but an MR id) ... probably not with the API as defined today. type/form/blvl are superseded by record attributes, so I think the best route forward is actually to teach QP how to do what we want. OTTOMH, something akin to the container() construct makes sense to me, and would be very simple to implement. Then we don't have to worry about how to add more, or more complicated, filtering options to constituent record retrieval in the future.

But, that's a tomorrow problem, IMO.

I'll leave the org/depth calculation stuff in place for the time being, in case we want to teach the middle layer method to be smarter.