Comment 3 for bug 1320301

Hmm, reviewed Blake's commit and have some thoughts...

1) In the upgrade script provided, he uses a hardcoded ID of 555 (but we've already gone past this number in stock seed data)

2) We need a change to the seed data file (Open-ILS/src/sql/Pg/950.data.seed-values.sql) to add the permission for fresh system installs. At which point in there, we'll define a proper ID for the new permission.

3) Do we need this permission applied to any staff groups by default (circ administrator, etc.?)

For the upgrade script, while I'm generally reluctant to specify an exact ID for the permissions, since these can and tend to be wildly variable in actual production systems, the expectation is that any custom permissions live above ID 1000, so anything under that is safe to insert. That said, we should add some protection in the upgrade script to fail peacefully if the permission was already added manually by the consortium in the past.

Marking back to "In Progress" and assigning to Blake for now to give this some more poking, but he may seek further assistance from folks with more DB upgrade script writing experience. And also, does this quality for a test plan and possible PGTap test?