Argument "" isn't numeric in numeric comparison

[Jason Stephenson]

Evergreen: 2.6.0
Postgresql: Irrelevant
Apache: 2.2.22
Ubuntu 12.04

    We get a number of messages like the following in our Apache error
    logs on a constant basis:

    Argument "" isn't numeric in addition (+) at
    /openils/var/templates/opac/parts/record/navigation.tt2 line 6.
    Argument "" isn't numeric in division (/) at
    /openils/var/templates/opac/results.tt2 line 1.
    Argument "" isn't numeric in numeric ge (>=) at
    /openils/var/templates/opac/parts/record/navigation.tt2 line 38.
    Argument "" isn't numeric in numeric gt (>) at
    /openils/var/templates/opac/myopac/holds/edit.tt2 line 106.
    Argument "" isn't numeric in numeric gt (>) at
    /openils/var/templates/opac/myopac/holds.tt2 line 42.
    Argument "" isn't numeric in numeric gt (>) at
    /openils/var/templates/opac/parts/place_hold.tt2 line 98.
    Argument "" isn't numeric in numeric gt (>) at
    /openils/var/templates/opac/parts/record/summary.tt2 line 56.
    Argument "" isn't numeric in numeric gt (>) at
    /openils/var/templates/opac/parts/result/table.tt2 line 87.
    Argument "" isn't numeric in numeric lt (<) at
    /openils/var/templates/opac/myopac/hold_history.tt2 line 122.
    Argument "" isn't numeric in numeric lt (<) at
    /openils/var/templates/opac/myopa/result/table.tt2 line 87.
    Argument "" isn't numeric in numeric lt (<) at
    /openils/var/templates/opac/myopac/hold_history.tt2 line 122.
    Argument "" isn't numeric in numeric lt (<) at
    /openils/var/templates/opac/myopac/holds.tt2 line 215.

I'll throw up a branch in a couple of days once I've had a chance to put it in production. I've tested it on my development and training servers.

[Jason Stephenson (jstephenson)]

I should add, you probably won't see these if you're logging Apache through syslog. We still use the old fashioned /var/log/apache2/error.log type setup.

[Jason Stephenson (jstephenson)]

We're using the modified tt2 files in production as of this morning. I will wait a couple of days before adding the pullrequest tag.

The changes are in the HEAD commit of this branch:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dyrcona/nonnumeric-argument-template-fix

[Jason Stephenson (jstephenson)]

Good thing I've waited on the pullrequest.

Staff found a problem with the place hold button on summary.tt2. A fix for that has been pushed to the above branch.

[Jason Stephenson (jstephenson)]

We've been running this branch in production since Thursday and have had no problems reported other than the one fixed by the second commit.

[Jason Stephenson (jstephenson)]

And, after adding the above comment, I checked the logs and found one that was slipping through still.

Apparently, attrs.marc_xml.findnodes('//*[local-name()="holdings" and @has_holdable="true"]').size in summary.tt2 was also coming up undefined at times.

So, pushed a third commit to repair that.

[Ben Shum (bshum)]

Pushed to master and backported to rel_2_6.