potential incorrect information display because of hard coded text value in hold_status.tt2

[Jim Keenan]

EG 2.4, 2.5
This is a relatively small thing but causes confusion for patrons.
In /openils/var/templates/opac/parts/hold_status.tt2
the line
[% l('[_1] hold on [quant,_2,circulating copy, circulating copies]',
hard codes the word "circulating".

When a patron looks at her holds, under status it will read "X hold on X circulating copies".

The problem is that holds can be placed on items which are only ON ORDER. Having the word "circulating" there gives the impression that there are actual copies available for borrowing.

I would like to see the word "circulating" removed from future versions of this file to avoid patron confusion.

[Victoria Lewis (vlewis-q)]

Removed two instances of the word "circulating" from the patron hold status message in the line
[% l('[_1] hold on [quant,_2,circulating copy, circulating copies]' from
/openils/var/templates/opac/parts/hold_status.tt2.

This takes into account that the copy count includes copies ON ORDER.

Here is the branch with the correction.
http://git.evergreen-ils.org/?p=working/Evergreen.git;a=commit;h=refs/heads/user/catalystit/lp1316814-incorrect_info_display

[Ben Shum (bshum)]

Assigning review target.

[Ben Shum (bshum)]

Seems logical to me. Picked to master for 2.7 series.

Thanks Victoria and Jim!