potential incorrect information display because of hard coded text value in hold_status.tt2

Bug #1316814 reported by Jim Keenan on 2014-05-06
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Evergreen
Medium
Unassigned

Bug Description

EG 2.4, 2.5
This is a relatively small thing but causes confusion for patrons.
In /openils/var/templates/opac/parts/hold_status.tt2
the line
[% l('[_1] hold on [quant,_2,circulating copy, circulating copies]',
hard codes the word "circulating".

When a patron looks at her holds, under status it will read "X hold on X circulating copies".

The problem is that holds can be placed on items which are only ON ORDER. Having the word "circulating" there gives the impression that there are actual copies available for borrowing.

I would like to see the word "circulating" removed from future versions of this file to avoid patron confusion.

Changed in evergreen:
assignee: nobody → Victoria Lewis (vlewis-q)
status: New → In Progress
Victoria Lewis (vlewis-q) wrote :

Removed two instances of the word "circulating" from the patron hold status message in the line
[% l('[_1] hold on [quant,_2,circulating copy, circulating copies]' from
/openils/var/templates/opac/parts/hold_status.tt2.

This takes into account that the copy count includes copies ON ORDER.

Here is the branch with the correction.
http://git.evergreen-ils.org/?p=working/Evergreen.git;a=commit;h=refs/heads/user/catalystit/lp1316814-incorrect_info_display

Changed in evergreen:
assignee: Victoria Lewis (vlewis-q) → nobody
tags: added: pullrequest
Ben Shum (bshum) wrote :

Assigning review target.

Changed in evergreen:
milestone: none → 2.next
status: In Progress → Triaged
importance: Undecided → Medium
Ben Shum (bshum) wrote :

Seems logical to me. Picked to master for 2.7 series.

Thanks Victoria and Jim!

Changed in evergreen:
milestone: 2.next → 2.7.0-alpha
status: Triaged → Fix Committed
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers