Support targeting and fulfillment of precat copy holds (for ILL)

Bug #1308239 reported by Bill Erickson
16
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Wishlist
Unassigned

Bug Description

Evergreen Next

Precat copies are a handy way to represent temporary items borrowed from an external lender (e.g. ILL partner). Today, though, Evergreen fails (unintentionally) to target holds on precat copies and it avoids (intentionally) fulfilling holds on precat copies during checkout. Removing these limitations on precat copy holds would make integration of FulfILLment, NCIP, and other ILL mediators that much easier.

It's already possible to create holds on precat copies via the API. The code to do the rest is minor and has been used to good effect with Evergreen servers patched to work with FulfILLment. Branch coming soon.

Revision history for this message
Bill Erickson (berick) wrote :
Changed in evergreen:
milestone: none → 2.next
assignee: Bill Erickson (erickson-esilibrary) → nobody
tags: added: holds pullrequest
Revision history for this message
Ben Shum (bshum) wrote :

Seems logical, pushed to master for 2.7.

Changed in evergreen:
milestone: 2.next → 2.7.0-alpha
status: New → Fix Committed
Revision history for this message
Bill Erickson (berick) wrote :

Just found a bug with this code which prevents precat checkouts when there is no hold. Yikes. Patch en route.

Changed in evergreen:
assignee: nobody → Bill Erickson (erickson-esilibrary)
status: Fix Committed → In Progress
Revision history for this message
Bill Erickson (berick) wrote :

Here's the error:

Can't call method "id" on an undefined value at /usr/local/share/perl/5.14.2/OpenILS/Application/Circ/Circulate.pm line 1795.

It's attempting to dereference a nonexistent $self->volume object. Patch pushed:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lplp1308239-precat-copy-holds-fix

Revision history for this message
Jason Stephenson (jstephenson) wrote :

Verified the checkout failure with the original code, then applied the branch in comment #4, and verified that checkouts work again.

Pushed the fix branch to master.

Thanks, Bill!

Changed in evergreen:
assignee: Bill Erickson (erickson-esilibrary) → nobody
status: In Progress → Fix Committed
Changed in evergreen:
status: Fix Committed → Fix Released
Revision history for this message
Katie Foster (kfoster) wrote :

A nice ILL process would be.

Check out pre-cat item to ILL card (make the pre-cat record).
Go to Item Status and request item with copy hold for the requesting patron.
Check in item from ILL card.
Item is routed to patron with copy hold.
--the process works up until this point--
Then when you go to check out the (pre-cat) hold for the patron it asks you to pre-cat the item again. Even though on their holds list it shows the pre-cat information before.

It would be nice to be able to use the original pre-cat information to have continuous circ on a pre-cat item.

This takes away the liability issue of checking out an item to a patron before they actually leave the building with it and the system would notify them of the hold rather than relying on an email from a staff member which is often an email address they are not used to looking for.

Revision history for this message
Andrea Neiman (aneiman) wrote :

Hi Katie - thanks for your thoughts. Since this is an closed bug, your suggestion might attract more attention if you filed it as a new "wishlist" bug report.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.