Support targeting and fulfillment of precat copy holds (for ILL)

Bug #1308239 reported by Bill Erickson on 2014-04-15
This bug affects 2 people
Affects Status Importance Assigned to Milestone

Bug Description

Evergreen Next

Precat copies are a handy way to represent temporary items borrowed from an external lender (e.g. ILL partner). Today, though, Evergreen fails (unintentionally) to target holds on precat copies and it avoids (intentionally) fulfilling holds on precat copies during checkout. Removing these limitations on precat copy holds would make integration of FulfILLment, NCIP, and other ILL mediators that much easier.

It's already possible to create holds on precat copies via the API. The code to do the rest is minor and has been used to good effect with Evergreen servers patched to work with FulfILLment. Branch coming soon.

Bill Erickson (berick) wrote :
Changed in evergreen:
milestone: none →
assignee: Bill Erickson (erickson-esilibrary) → nobody
tags: added: holds pullrequest
Ben Shum (bshum) wrote :

Seems logical, pushed to master for 2.7.

Changed in evergreen:
milestone: → 2.7.0-alpha
status: New → Fix Committed
Bill Erickson (berick) wrote :

Just found a bug with this code which prevents precat checkouts when there is no hold. Yikes. Patch en route.

Changed in evergreen:
assignee: nobody → Bill Erickson (erickson-esilibrary)
status: Fix Committed → In Progress
Bill Erickson (berick) wrote :

Here's the error:

Can't call method "id" on an undefined value at /usr/local/share/perl/5.14.2/OpenILS/Application/Circ/ line 1795.

It's attempting to dereference a nonexistent $self->volume object. Patch pushed:;a=shortlog;h=refs/heads/user/berick/lplp1308239-precat-copy-holds-fix

Jason Stephenson (jstephenson) wrote :

Verified the checkout failure with the original code, then applied the branch in comment #4, and verified that checkouts work again.

Pushed the fix branch to master.

Thanks, Bill!

Changed in evergreen:
assignee: Bill Erickson (erickson-esilibrary) → nobody
status: In Progress → Fix Committed
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers