Business::Stripe can fail to be installed

Bug #1306176 reported by Galen Charlton on 2014-04-10
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Evergreen
Undecided
Unassigned

Bug Description

Attempting to install Business::Stripe can fail on some platforms, including Debian Jessie (and probably Ubuntu Trusty).

This is because it has Test::Pod test cases, but as of the release of Pod::Simple 3.24, B::Stripe's use of "=item" elements is now invalid. Since Test::Pod interprets warnings as failures, platforms that have a recent enough version of Pod::Simple will refuse to install Business::Stripe from CPAN without forcing it.

Since the failing test cases are /only/ for POD, as a temporary measure I suggest putting Business::Simple in the CPAN_MODULES_FORCE list.

Evergreen master

Revision history for this message
Galen Charlton (gmc) wrote :

One consequence is that if someone installing Evergreen fails to notice that Business::Stripe didn't get installed, attempting to log in with the staff client will get an error complaining that the open-ils.circ.circ_modifier.retrieve.all method does not exist.

Changed in evergreen:
milestone: none → 2.6.0
tags: added: pullrequest
Revision history for this message
Galen Charlton (gmc) wrote :

A patch is available at the tip of the user/gmcharlt/lp1306176_force_business_strip_install branch in the working/Evergreen repository:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/gmcharlt/lp1306176_force_business_strip_install

Note that while I've targeted this bug to Evergreen 2.6.0, it's borderline whether this is a release blocker or not.

Revision history for this message
Galen Charlton (gmc) wrote :

The issue was reported to the maintainer of Business::Stripe five months ago:

https://github.com/aquaron/Business-Stripe/pull/2

I have added a comment in support of a pending pullrequest to fix it.

Revision history for this message
Bill Erickson (berick) wrote :

"debian-wheezy" tested. Leaving un-merged for now so others can test.

Sign-off commit pushed to:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1306176_force_business_strip_install

Changed in evergreen:
status: New → Confirmed
Revision history for this message
Dan Wells (dbw2) wrote :

Thanks for testing, Bill. I think this is straightforward enough that we can run with it for 2.6.0.

Thanks, Galen!

Changed in evergreen:
status: Confirmed → Fix Committed
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers