Copy table header is wrong - and questionable practice

Bug #1305958 reported by Dan Scott
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Undecided
Unassigned
2.7
Undecided
Unassigned

Bug Description

* Evergreen master

Currently there is a <td headers='copy_header_date_format'> entry in copy_table.tt2 that doesn't actually link to an associated table header with an ID of that value. It should be <td headers='copy_header_create_date'>

However, per http://webaim.org/techniques/tables/data the current recommendation is to avoid the use of the headers approach in favour of the much simpler scope attribute for headers (one of the reasons being that as things change, they get out of alignment and errors are unlikely to be noticed... as happened here. Heh.)

Revision history for this message
Dan Scott (denials) wrote :
Revision history for this message
Dan Scott (denials) wrote :
tags: added: pullrequest
tags: added: accessibility
Changed in evergreen:
milestone: none → 2.6.0
Revision history for this message
Dan Wells (dbw2) wrote :

I took the "conservative" fix, but retargeting to 2.6.1 to get some eyes on the better fix. (To any potential testers, remember you'll need to revert the other branch, or do some minor massaging to get the second branch to apply.) Thanks, Dan!

Changed in evergreen:
status: New → Confirmed
milestone: 2.6.0 → 2.6.1
Changed in evergreen:
milestone: 2.6.1 → 2.6.2
Galen Charlton (gmc)
Changed in evergreen:
milestone: 2.6.3 → 2.6.4
Revision history for this message
Chris Sharp (chrissharp123) wrote :

Copy table loads correctly on a rebased master using the "better practice" branch. Signoff branch here:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/csharp/lp1305958_th_scope_signoff

Revision history for this message
Ben Shum (bshum) wrote :

I took csharp's signoff and pushed it to master and rel_2_7. rel_2_6 has a conflict and needs some massaging to apply if we wish to backport there too?

Changed in evergreen:
milestone: 2.6.4 → none
status: Confirmed → Fix Committed
Changed in evergreen:
status: Fix Committed → Fix Released
no longer affects: evergreen/2.6
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers