ISBNs should be cleaned up in record summary output

Bug #1303544 reported by Dan Scott on 2014-04-07
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Status tracked in Master

Bug Description

* Evergreen master

That fine old 020 $a that contains a value like "1582406723 (pbk.)" means that we are publishing assertions that the ISBN of a book is "1582406723 (pbk.)" when it is really "1582406723". You can see this problem in the sample data set in the record for "The walking dead", where in record details we publish:

<li><span class="rdetail_value" property="isbn">9781582406725 (pbk.)</span></li>

... whereas we should really publish:

<li><span class="rdetail_value" property="isbn">9781582406725</span> (pbk.)</li>

Note that the MARC21 standard now allows for "(pbk.) to be placed in $q instead, which would be really nice.

Revision history for this message
Dan Scott (denials) wrote :
tags: added: pullrequest
Revision history for this message
Ben Shum (bshum) wrote :

Hmm, not sure what's going on with the change to misc_util.tt2 (adding .trim to the end of ISBN/UPC/ISSN) because it causes those values to completely disappear from view in the catalog.

However, with just the changes in record/summary.tt2, it seems to do what's advertised and putting the extra parts outside the span.

Verifying once more tomorrow before splitting this commit and pushing it.

Revision history for this message
Ben Shum (bshum) wrote :

Decided to push just the fix for summary, never did quite figure out what the change for .trim was.

Pushed to master, rel_2_6 and rel_2_5. Thanks Dan!

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers