remove deprecated script osrf_ctl.sh

Bug #1286248 reported by Galen Charlton
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
High
Unassigned
OpenSRF
Wishlist
Unassigned

Bug Description

As of 2.3.0, osrf_ctl.sh was deprecated in favor of osrf_control. It should be removed entirely for 2.4.

Revision history for this message
Galen Charlton (gmc) wrote :

Also linking the bug to Evergreen to remove references to osrf_ctl.sh.

Changed in evergreen:
milestone: none → 2.6.0-rc1
importance: Undecided → Wishlist
Revision history for this message
Galen Charlton (gmc) wrote :

Patches are available now for both Evergreen and OpenSRF:

Evergreen: working/user/gmcharlt/lp1286248_remove_references_to_osrf_ctl

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/gmcharlt/lp1286248_remove_references_to_osrf_ctl

OpenSRF: working/user/gmcharlt/lp1286248_remove_osrf_ctl

http://git.evergreen-ils.org/?p=working/OpenSRF.git;a=shortlog;h=refs/heads/user/gmcharlt/lp1286248_remove_osrf_ctl

tags: added: pullrequest
Galen Charlton (gmc)
tags: added: 2.6-rc-blocker
Revision history for this message
Dan Wells (dbw2) wrote :

I've looked this over and it looks fine, but I'd like someone who uses bricks to check on the brick related portion if possible.

One other minor note, I don't think the comment starting on line 188 really applies any more, since that logic is now in osrf_control.

Revision history for this message
Dan Wells (dbw2) wrote :

Gave this a second look, still looks good. Pushed to master. Thanks, Galen!

Changed in evergreen:
status: New → Fix Committed
importance: Wishlist → High
Galen Charlton (gmc)
tags: added: deprecation
Changed in evergreen:
status: Fix Committed → Fix Released
Revision history for this message
Bill Erickson (berick) wrote :

OpenSRF patch pushed to master now as well.

Changed in opensrf:
status: New → Fix Committed
Galen Charlton (gmc)
Changed in opensrf:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers