Simplified Hold Pull List does not filter on item status

[Jason Etheridge]

There are situations where a row in action.hold_request can have a value set in the current_copy column, where the item referenced can have a status other than Available or Reshelving. The Simplified Pull List will show these, and it's difficult to pull such items. :-) The other pull list interfaces do not show these.

I thought that the hold retargeter would fix such records in time, but this does not appear to be the case. I also thought that such data wouldn't occur with normal Evergreen workflows, and only showed up sometimes with migrated data, but this also doesn't appear to be the case.

I don't know which is more important to tackle, the way current_copy gets set and reset, or the discrepancy in behavior between the different hold pull list interfaces, but I'm letting this ticket focus on the latter. I don't have any code to contribute at this time.

[Michele Morgan (mmorgan)]

One of our libraries has just run into this issue on our 2.4.4 system. An item appeared on their pull list. They could not locate it and changed its status to Missing. The item no longer appears when they retrieve the On Shelf Pull List in the client, but accessing the Simplified Pull List does show the item with status Missing. Screen shots attached.

[Thomas Berezansky (tsbere)]

I have code for this one!

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/tsbere/ahopl_limit_to_available

Also, a short list of normal workflows that I know can result in this and that I used for testing:

Force/Recall hold is placed on an item that is not in Available or Reshelving status

Any hold is placed, hold targeter targets the copy, and then the copy is edited to have a different status (say, being moved to cataloging)

[Ben Shum (bshum)]

Sounds like a bug to me, adding targets.

[Michele Morgan (mmorgan)]

I have tested this code and consent to signing off on it with my email address, <email address hidden>, and name, Michele Morgan.

[Ben Shum (bshum)]

Thanks for testing Michele! Added your signoff line to tsbere's code and pushed this fix to master, rel_2_6 and rel_2_5.