Holds history displays canceled holds as active

Bug #1275118 reported by Kathy Lussier on 2014-01-31
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Evergreen
Medium
Unassigned

Bug Description

When a patron is tracking holds history, canceled holds display as active. From the patron point of view, the hold is no longer active after it has been canceled. Ideally, it would be nice to display canceled here, but inactive would do too.

Ben Shum (bshum) on 2014-02-16
Changed in evergreen:
status: New → Triaged
importance: Undecided → Medium
Kathy Lussier (klussier) on 2014-07-18
description: updated
Changed in evergreen:
assignee: nobody → Terran McCanna (tmccanna)
Terran McCanna (tmccanna) wrote :

I've submitted a suggested fix for this:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=commit;h=0726f21ecca8ec80afecde14def6d4885ae3563e

To test, make sure a test patron's hold history settings are enabled. Then, set a number of holds on the account and then suspend some of them and cancel some of them. Check the patron's hold history page to be sure the statuses are appearing correctly.

Changed in evergreen:
assignee: Terran McCanna (tmccanna) → nobody
tags: added: pullrequest
Erica Rohlfs (erohlfs) on 2016-03-03
Changed in evergreen:
assignee: nobody → Erica Rohlfs (erohlfs)
Erica Rohlfs (erohlfs) wrote :

Looks good. Under the "Active" column, the suspended holds read "Suspended" and the canceled holds read "Canceled."

I have tested this code and consent to signing off on it with my name, [Erica Rohlfs] and email address, [<email address hidden>].

Kathy Lussier (klussier) on 2016-03-04
Changed in evergreen:
assignee: Erica Rohlfs (erohlfs) → Kathy Lussier (klussier)
Kathy Lussier (klussier) wrote :

This looks great Terran! I signed off on your commit and added Erica's signoff to the commit too.

When I was looking at it, I realized that the fulfilled holds also should not display as active since a user would consider those holds to be complete. I added a commit on top of the branch to change those holds to display as fulfilled. In the Active column, then, we would have active holds and three different types of holds users may consider to be no longer active: suspended, canceled and fulfilled.

While I was there, I also changed the "Active On" column header to "Activate" to make it more consistent with the label used in the regular holds interface. I also though the label was a better reflection of what is displaying in that column. New working branch at http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/kmlussier/lp1275118_myopac_canceled_holds

Thank you Terran and Erica!

Changed in evergreen:
assignee: Kathy Lussier (klussier) → nobody
milestone: none → 2.10-rc
Galen Charlton (gmc) wrote :

I've pushed Terran's patch. Thanks!

I did not push Kathy's follow-up, as it introduces a template syntax error that it turns leads to an internal server error:

 egweb: template error: file error - parse error - opac/myopac/hold_history.tt2 line 105-111: unexpected token (l)\n [% IF ahr.fulfillment_time;\n l('Fulfilled');\n ELSIF hold.hold.status == 6;\n l('Canceled'); \n ELSE \n l(ahr.frozen == 'f' ? 'Active' : 'Suspended');\n

I agree with Kathy about not displaying fulfilled holds as active, but please open a new bug for that and rework that follow-up patch.

Changed in evergreen:
status: Triaged → Fix Committed
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers