"Auto-Print" checkbox next to "Done" on the "Checkout" tab does not remember checked state between patron retrieval

Bug #1275074 reported by Srey Seng
20
This bug affects 4 people
Affects Status Importance Assigned to Milestone
Evergreen
Medium
Unassigned
2.5
Medium
Unassigned

Bug Description

EG master (2014-01-31)

On earlier versions of Evergreen, the Auto-Print checkbox next to the Done button on the Checkout screen remembers the checked state between patron retrieval.

On master, the Auto-Print checkbox no longer remains checked in between patron retrieval.

Revision history for this message
Srey Seng (sreyseng) wrote :
summary: "Auto-Print" checkbox next to "Done" on the "Checkout" tab does not
- remember checked state between patrons retrieval
+ remember checked state between patron retrieval
Revision history for this message
Jason Stephenson (jstephenson) wrote :

I have confirmed this on my development system. The check box does not stay checked between patrons there. This is master as of 2014-01-27.

The check box does stay checked between patrons on our production clients. These were built from master as of 2013-12-08.

This makes it look like a recent change.

Changed in evergreen:
status: New → Confirmed
importance: Undecided → Medium
Revision history for this message
Ben Shum (bshum) wrote :

I found the bad commit. Turned out to be http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=bb4a797010201d6f26156c9e921d78690f265e35 which came out of work in bug 1243280.

Reverting the commit fixes the problem for me and I confirmed with Jason that it was a mistake commit.

Pushed the revert action to master.

Revision history for this message
Ben Shum (bshum) wrote :

And also found and reverted it in the rel_2_5 branch as well...

Changed in evergreen:
status: Confirmed → Fix Committed
Revision history for this message
Holly Brennan (hollyfromhomer) wrote :

This also affects the stickiness of the checkbox in the serials module. When batch receiving, the checkbox in the bottom right corner (Create Units for Received Items) used to remember its setting, and stay checked or not until manually changed. Upgraded from 2.3.4 to 2.5.2 yesterday, and now it doesn't do this.

Hooray that a fix is already in the works!

Revision history for this message
Jason Etheridge (phasefx) wrote :

Here's how to hand-patch for those who need to do this:

On each of your Apache servers:

cd /openils/var/web/xul/server/OpenILS/
wget -O lp1275074.patch 'http://git.evergreen-ils.org/?p=Evergreen.git;a=patch;h=db7b99e8ccba2ebf81a345157de5a90ba5387626'
patch --dry-run global_util.js lp1275074.patch

If you see "patching file global_util.js" with no error reported, then do it for real with:

patch global_util.js lp1275074.patch

Revision history for this message
Holly Brennan (hollyfromhomer) wrote :

This patch ALSO fixes the stickiness of the checkbox for Flat-Text Editor in MARC Edit.

Dan Wells (dbw2)
Changed in evergreen:
milestone: none → 2.6.0-rc1
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers