Allow Located URIs to supply copy-like visibility to bibs

Bug #1271630 reported by Mike Rylander on 2014-01-22
This bug affects 1 person
Affects Status Importance Assigned to Milestone

Bug Description

Currently, Evergreen restricts the visibility of bibliographic records that make use of Located URIs in a way that attempts to model licensing restrictions. It has been suggested that we should add an option to allow Located URIs to act in a way analogous to copies for visibility testing.

Related, to improve Located URI display generally, we should use the same preferred-library ranking that copies do. The general Located URI code supports this already, but the unapi method is not making use of it. We'll simply have it make use of the data available to it.

Mike Rylander (mrylander) wrote :
Changed in evergreen:
milestone: 2.6.0-alpha1 → 2.6.0-beta1
tags: added: pullrequest
Mike Rylander (mrylander) wrote :

I've pushed a minor update to this that teaches the in-db Located URI code how to respect the new visibility flag.

Mike Rylander (mrylander) wrote :

I've pushed a bug fix for duplicated URI display to the branch. All should be ready for merge now.

Mike Rylander (mrylander) wrote :

Assuming both this and the metarecord holds patch get into 2.6, one or the other will need minor adjustment depending on commit order. They both touch the evergreen.located_uris() stored procedure in different ways. I'm happy to address that once one or the other is committed to master.

Elizabeth Thomsen (et-8) wrote :

We have tested this and it works as it should:

The consortium level scope displays records and links that are located to any system or branch

The system level scope displays records and links that are located to that system or its branches

The branch level scope displays records and links that are located to that specific branch

Jeff Godin (jgodin) on 2014-02-11
Changed in evergreen:
assignee: nobody → Jeff Godin (jgodin)
status: New → In Progress
Jeff Godin (jgodin) wrote :

I've done an initial review and this looks good. I plan to test before end of day tomorrow (Wed).

Dan Wells (dbw2) on 2014-02-17
tags: added: 2.6-beta-blocker
Jeff Godin (jgodin) wrote :

Tests well and rebased to master with only minor changes for ARRAY_ACCUM -> ARRAY_AGG per bug 874296.

Pushed to master. Thanks, Mike and Elizabeth!

Changed in evergreen:
status: In Progress → Fix Committed
assignee: Jeff Godin (jgodin) → nobody
Kathy Lussier (klussier) on 2014-06-26
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers