The KPAC side looked very nice to me Dan. Thanks for your hard work on that piece of it.
Couple issues though for the regular TPAC -- the record and result (with more details) views were broken with apache Internal Server Errors. Looking at my logs I found this:
open-ils.cstore 2014-01-24 23:54:03 [ERR :3345:oils_sql.c:5585:13906237963958117] open-ils.cstore: Error with query [SELECT * FROM actor.org_unit_ancestor_setting( 'lib.info_url', '' ) AS "actor.org_unit_ancestor_setting" ;]: 0 ERROR: invalid input syntax for integer: ""
LINE 1: ... actor.org_unit_ancestor_setting( 'lib.info_url', '' ) AS "a... ^
Digging deeper, I found that when we pulled out the code that makes the URLs into its separate file, there was a move to make "copy_info = copy;" but this was not present in the results/copy_table.tt2 file (which broke all more detailed results). Unfortunately, the record one was also broken, because it was backwards, and it really wanted "copy = copy_info;"
I've signed off on the commits in the branch, and added a new commit at the top to address the variables issue.
The KPAC side looked very nice to me Dan. Thanks for your hard work on that piece of it.
Couple issues though for the regular TPAC -- the record and result (with more details) views were broken with apache Internal Server Errors. Looking at my logs I found this:
open-ils.cstore 2014-01-24 23:54:03 [ERR :3345:oils_ sql.c:5585: 139062379639581 17] open-ils.cstore: Error with query [SELECT * FROM actor.org_ unit_ancestor_ setting( 'lib.info_url', '' ) AS "actor. org_unit_ ancestor_ setting" ;]: 0 ERROR: invalid input syntax for integer: "" unit_ancestor_ setting( 'lib.info_url', '' ) AS "a...
^
LINE 1: ... actor.org_
Digging deeper, I found that when we pulled out the code that makes the URLs into its separate file, there was a move to make "copy_info = copy;" but this was not present in the results/ copy_table. tt2 file (which broke all more detailed results). Unfortunately, the record one was also broken, because it was backwards, and it really wanted "copy = copy_info;"
I've signed off on the commits in the branch, and added a new commit at the top to address the variables issue.
See branch: user/bshum/ tpac_library_ results
http:// git.evergreen- ils.org/ ?p=working/ Evergreen. git;a=shortlog; h=refs/ heads/user/ bshum/tpac_ library_ results