Regression tests are failing due to change in sample data

Bug #1267317 reported by Dan Scott
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Undecided
Unassigned

Bug Description

* Evergreen master

Steps to reproduce: cd Open-ILS/src/perlmods; prove -l lib -t live_t

What happens: several regression tests fail

Expected: All regression tests pass

When we added more realistic sample data for org units, we broke several of the regression tests in Open-ILS/src/perlmods/live_t that expected the default hours of operation for BR4. Options included making the regression tests less fragile in the first place (for example, creating a brand new org unit or explicitly setting default hours of operation for BR4) but the simplest / fastest method is to simply revert BR4 back to default hours and use BR1 as the more interesting guinea pig instead.

See http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dbs/fix_regression_test_regression for a branch that changes BR4 back to default hours of operation; BR1 takes its place.

Tags: pullrequest
Dan Scott (denials)
Changed in evergreen:
milestone: none → 2.next
tags: added: pullrequest
Bill Erickson (berick)
Changed in evergreen:
status: New → In Progress
assignee: nobody → Bill Erickson (erickson-esilibrary)
Revision history for this message
Bill Erickson (berick) wrote :

Change applied, tests tested. Merged to master. Thanks, Dan.

Changed in evergreen:
status: In Progress → Fix Committed
assignee: Bill Erickson (erickson-esilibrary) → nobody
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.