Missing/incorrect regex for authority in Vandelay.pm

Bug #1266937 reported by Srey Seng on 2014-01-07
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Evergreen
Undecided
Unassigned
2.4
Undecided
Unassigned
2.5
Undecided
Unassigned

Bug Description

EG Master (01/07/2014)

File: Vandelay.pm, in function import_record_list_impl

---
1.
---
On line 934, there is the following code: $auto_overlay_func = s/bib/auth/o

This is missing a "~" in order for 'auth' to replace 'bib'.
So, the corrected code is: $auto_overlay_func =~ s/bib/auth/o

Restoring the missing "~" correctly modified the value of the $auto_overlay_func variable from vandelay.auto_overlay_bib_record to vandelay.auto_overlay_auth_record.

However, there is no such method in the database in the vandelay schema named vandelay.auto_overlay_auth_record, only (the next closest one) vandelay.auto_overlay_authority_record

So, the corrected code is now: $auto_overlay_func =~ s/bib/authority/o;

---
2
---
In the same way, on line 933, there is the following code: $overlay_func =~ s/bib/auth/o;
This modified the value of the variable $overlay_func from "vandelay.overlay_bib_record" to "vandelay.overlay_auth_record".

However, there is no such method in the database in the vandelay schema named vandelay.overlay_auth_record, only (the next closest one) vandelay.overlay_authority_record

---

The fact that auth overlaying is not available via the Batch Marc Importer / Exporter is perhaps one of the reasons why the missing "~" went unnoticed.

Going to use this as an opportunity to learn how to push to the working repo.
Branch to come with the changes detailed above.

Bill Erickson (berick) wrote :

The fix looks good. I've merged the change to 2.4 and up.

In the future, when a patch is ready, please add a "pullrequest" tag to the ticket.

Thanks, Srey!

Changed in evergreen:
milestone: none → 2.next
status: New → Fix Committed
Srey Seng (sreyseng) wrote :

Great, I will do so in the future, thanks!

Yamil (ysuarez) on 2014-01-14
tags: added: authority
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers