Current Bills screen shows duplicate charges when check-in is done from items out tab

Bug #1261835 reported by Carrie Curie
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Low
Unassigned
2.10
Fix Released
Low
Unassigned
2.11
Fix Released
Low
Unassigned

Bug Description

Evergreen 2.4.3, 2.5.1

When checking in an item by using the right-click/menu option of "Check in" from the Items Out screen, the current Bills section of the bills screen does not refresh correctly. It creates duplicate list entries for each listed transaction. It additionally counts all valid and duplicate entries in the totals listed in that panel. The correct amount owed is showed in the summary pane and the summary amount listed under the Bills button. Please refer to the attached screenshot.

Manually refreshing the screen will correct the issue, though.

Revision history for this message
Carrie Curie (carrie-curie) wrote :
Revision history for this message
Erica Rohlfs (erohlfs) wrote :

Confirmed in version 2.6.3

Changed in evergreen:
status: New → Confirmed
Changed in evergreen:
assignee: nobody → Jason Etheridge (phasefx)
Revision history for this message
Jason Etheridge (phasefx) wrote :

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/collab/phasefx/lp1261835

collab/phasefx/lp1261835 @ working/Evergreen.git

commit 44d71aaf4fd124b95baa002715902a7972c1f0d9 (HEAD, working/collab/phasefx/lp1261835, lp1261835)
Author: Jason Etheridge <email address hidden>
Date: Wed Nov 2 14:28:08 2016 -0400

    lp1261835 stop colliding bill UI refreshes

    for want of promises in Angular :)

    population of the bill list in this implementation is asynchronous, but the rest
    of the refresh action is not, and it's sadly being invoked multiple times. There
    are different ways to fix this, but using a semaphore seems to work.

    Signed-off-by: Jason Etheridge <email address hidden>

tags: added: pullrequest
Changed in evergreen:
assignee: Jason Etheridge (phasefx) → nobody
Changed in evergreen:
milestone: none → 2.12-beta
Dawn Dale (ddale)
Changed in evergreen:
assignee: nobody → Dawn Dale (ddale)
Changed in evergreen:
milestone: 2.12-beta → 2.12-rc
Revision history for this message
Dawn Dale (ddale) wrote :

I have tested this code and consent to signing off on it with my email address, [<email address hidden>], and name, [Dawn Dale]

Changed in evergreen:
assignee: Dawn Dale (ddale) → nobody
tags: added: signedoff
Revision history for this message
Kathy Lussier (klussier) wrote :

Thank you Jason and Dawn! Let's get this one in before the xul client goes away.

Merged to master, release 2.11 and release 2.10

Changed in evergreen:
status: Confirmed → Fix Committed
importance: Undecided → Low
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.