The label on the desk renewal global flag is misleading

Bug #1260481 reported by Steve Callender on 2013-12-12
This bug affects 1 person
Affects Status Importance Assigned to Milestone

Bug Description

The text on the circ.desk_renewal.use_original_circ_lib global flag states that this setting is to use the original circ library rather than the user home library. Desk renewals use the workstation library instead of the user home library.

The following patch corrects this text to properly explain the setting.;a=commit;h=9094441e73ce9df09092ade563670f37b3e50900

Jason Etheridge (phasefx) wrote :

I don't know how important it really is, but we may want to use oils_i18n_gettext in the upgrade script like we're doing in the seed data.

Ben Shum (bshum) wrote :

"the oils_i18n flag isn't processed in upgrade scripts, only on the base schema" -- dbs in #evergreen IRC on 2013-12-17

So based on that, we're not going to deal with that in the upgrade script.

Tested and works for me. Had to re-read the description a couple times to understand what I did wrong when I initially created the global flag. Good catch Steve, thanks for the patch!

Picked to master and rel_2_5.

Changed in evergreen:
milestone: none → 2.5.2
importance: Undecided → Low
status: New → Fix Committed
Ben Shum (bshum) on 2014-02-16
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers