"Alias" in Patron Search needs to be labeled "Holds Alias" for clarity/consistency

[Chris Sharp]

From one of our 2.5 testers comes a request to re-label "Alias" in the Patron Search interface to "Holds Alias". Since 11/2008, the patron registration interface (via the IDL) has labled this "OPAC/Staff Client Holds Alias". I propose changing the Patron Search interface to the abbreviated "Holds Alias" form.

Branch at working:user/csharp/change_alias_label_in_patron_search.

Evergreen Master
OpenSRF 2.2
PostgreSQL 9.1.10
Ubuntu 12.04 LTS

[Ben Shum (bshum)]

Simple change that I can get behind. Question though, do we backport string changes like this? Or perhaps this is a situation where from 2.6 onwards, we call it "hold alias" but so that translation doesn't get broken for 2.5 and earlier, we shouldn't backport this modification to the language?

Ready to pick and merge this wherever once we know how we would like to proceed.

[Dan Wells (dbw2)]

I'm fine with not backporting this for the reason given. Removing the 2.5 target. If others feel differently, we'll need to solve the translation problem before pushing this in (which we should do anyway, at some point, but that would need a champion to step up).

[Ben Shum (bshum)]

Sounds good. Pushed to master!