In the staff client, the submit hold button is not activating when placing hold

Bug #1251424 reported by Steve Callender on 2013-11-14
This bug affects 1 person
Affects Status Importance Assigned to Milestone

Bug Description

I've moved the initializing of the cur_hold_barcode variable
to within the function rather than floating outside of it.
This seemed to fix an intermittent issue where the submit
button would not become activatable when first going to the
place hold screen via the staff client. To create the hold,
the user had to cycle through the "Place hold by patron barcode"
option and then back to "Place hold for me" option.

It looked like behind the scenes for certain org units that
cur_hold_barcode would not be set and the button will not open until
it at least has something. This change causes it to be set on the inital
loading of the screen so the hold can be placed properly.

This definitely needs to be vetted by someone else. I do know that
making this change fixed the issue I was having, but I do not see this
issue come up everywhere and could not determine why it sometimes works.
However the code itself just didn't look right to me so I made this change.

Patch can be found here,;a=commit;h=2de8747fc4fb0cb619667db6723338611e5dfd9b


Ben Shum (bshum) wrote :

Confirmed as an issue. Applying Steve's patch dealt with the Submit button strangeness quite nicely.

Picked to master and backported to rel_2_5, rel_2_4, and rel_2_3.

Changed in evergreen:
status: New → Fix Committed
importance: Undecided → Low
milestone: none → 2.5.1
Ben Shum (bshum) on 2013-12-06
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers