Use the juvenile setting when auto-removing juvenile flag.

Bug #1251415 reported by Steve Callender on 2013-11-14
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Evergreen
Wishlist
Unassigned

Bug Description

When calling the API open-ils.storage.actor.user.juvenile_to_adult, most notably
from the juv_to_adult.srfsh support script, instead of strictly using the
hardcoded passed value, first check the global.juvenile_age_threshold from
the settings based on the users home library. If the setting does not exist,
then fall back on the hard coded passed value.

This will allow each library to be able to set different juvenile thresholds
if needed and at the very least, give control to the settings rather than
rely strictly on the hardcoded passed value.

Patched against master 11/14/2013.

Patch can be found here,

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=commit;h=9f24e46782027a4ea19120116fdba13bb6939571

Ben Shum (bshum) wrote :

Marking initial review target. Not sure if this qualified as a bug fix or as a new feature?

Changed in evergreen:
status: New → Triaged
milestone: none → 2.6.0-rc1
Changed in evergreen:
milestone: 2.6.0-rc1 → 2.next
Kathy Lussier (klussier) wrote :

Hmmm...I'm leaning towards new feature, and one that could probably use a brief release notes entry too.

tags: added: needsreleasenote
Kathy Lussier (klussier) on 2014-11-10
Changed in evergreen:
importance: Undecided → Wishlist
Bill Erickson (berick) wrote :

I pushed a sign-off to Steve's commit. At the risk of hijacking the bug, I pushed a second commit that adds "AND deleted IS FALSE" to the WHERE clause to avoid processing deleted users. The second commit also has some reformatting for readability / avoiding wide columns. If this change seems reasonable, I'll push a live test.

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/collab/berick/lp1251415-juv-to-adult-setting

Changed in evergreen:
assignee: nobody → Bill Erickson (berick)
tags: added: test-writing-day-0
Bill Erickson (berick) wrote :

Pushed live test to confirm org setting takes precedence and to confirm deleted users are not modified. Includes pull of current master, so commits are spread about.

Changed in evergreen:
assignee: Bill Erickson (berick) → nobody
status: Triaged → Confirmed
Bill Erickson (berick) wrote :

Adding release notes...

Changed in evergreen:
assignee: nobody → Bill Erickson (berick)
Bill Erickson (berick) wrote :

Rebased to current master and pushed release notes.

Changed in evergreen:
assignee: Bill Erickson (berick) → nobody
tags: removed: needsreleasenote
Galen Charlton (gmc) wrote :

Run through its paces and pushed to master. Thanks, Steve and Bill!

Changed in evergreen:
assignee: nobody → Galen Charlton (gmc)
assignee: Galen Charlton (gmc) → nobody
status: Confirmed → Fix Committed
Liam Whalen (whalen-ld) on 2015-11-17
tags: removed: test-writing-day-0
Changed in evergreen:
milestone: 2.next → 2.10-beta
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers