staff client localstore.rdf can grow too large

Bug #1249480 reported by Jason Etheridge
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Fix Released
Won't Fix
Fix Released

Bug Description

This is because we were inadvertently still using the @persist mechanism (in column definitions for util.list), which is tied to complete URL's, including query parameters like record id's which change often.

This branch fixes that:
collab/phasefx/bloated_localstore @ working/Evergreen.git;a=shortlog;h=refs/heads/collab/phasefx/bloated_localstore

I saw one example localstore.rdf file that was 65M in size. That may not sound bad until you realize that this is an XML file that has to be parsed.

-- Jason

Tags: pullrequest
Revision history for this message
Ben Shum (bshum) wrote :

This sounds evil Jason. I'm going to add it to my list of things to take a look at and make sure we try to include it as some sort of bug fix if possible...

Changed in evergreen:
assignee: nobody → Ben Shum (bshum)
status: New → Triaged
importance: Undecided → Medium
milestone: none → 2.6.0-rc1
Revision history for this message
Jason Etheridge (phasefx) wrote : Re: [Bug 1249480] Re: staff client localstore.rdf can grow too large

We should probably push the persist changes through to prevent the
problem from getting worse, while we figure out what to do about
existing localstore.rdf's that may be too large.

Revision history for this message
Ben Shum (bshum) wrote :

Sounds reasonable. I pushed it to master, but encountered issues with the pick to rel_2_4, so I'm going to leave backporting for a later time if we feel more confident to backport later.

Changed in evergreen:
status: Triaged → Fix Committed
assignee: Ben Shum (bshum) → nobody
Revision history for this message
Mike Rylander (mrylander) wrote :

Just using ack, there's one remaining use of @persist='hidden width ordinal' on line 2465 of circ/util.js. I think that may have been missed simply due to the quoting style (" instead of '), though I could be wrong and "patron_alias" may need that? In any case, I spotted it when attempting to backport to 2.4. It's non-trivial (floating groups changed adjacent code) so I'm leaving it alone for 2.4, unless someone else wants to jump on it.

Revision history for this message
Jason Etheridge (phasefx) wrote :

collab/phasefx/bloated_localstore2 @ working/Evergreen.git against master for the lingering persist Mike found. Thanks Mike! Don't know if this should be on a separate bug for the Fix Committed goodness, etc.

Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.