auth overlay needs to include indicators and not generate junk tags

Bug #1247220 reported by Mike Rylander on 2013-11-01
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Critical
Unassigned
2.4
Undecided
Unassigned

Bug Description

Marking this Crit, as it breaks (at least) master's auth overlay functionality.

First, we were not supplying authority tag indicators when generating the
overlay template. The xml merge function does not currently transfer
indicators, but we need to do this anyway because newer MARC::Field version
balk at fields with no indicators.

Second, PG 9.1+ adds wrapper tags to xml content that is passed to XMLELEMENT
as an array. So, we'll use XMLAGG to get around that.

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/miker/auth_indicators_and_junk

Thanks to Dan Wells for spotting the problem and overlay-side causes of breakage.

Dan Wells (dbw2) on 2013-11-01
Changed in evergreen:
status: New → Fix Committed
Dan Wells (dbw2) wrote :

Tested on a 9.1 DB, and it fixed the issue I was having. Pushed to master and rel_2_4, with many thanks.

Two things to note:

1) As mentioned to Mike in IRC, the indicators pulled from the authority side work in the bib side in some cases (e.g. auth 100/bib 100) but not others (e.g. auth 150/bib 650). Since the overlay process doesn't care out indicators at this time, it doesn't hurt anything, but when/if it does care, we may need work out a more completely correct solution.

2) I am leaving this open for 2.3 because that version of EG didn't require PG 9.1 (though it was recommended). Can anyone verify that this fix still works on 9.0? If so, please push to rel_2_3.

Thanks again, Mike!

Dan Wells (dbw2) on 2013-11-11
Changed in evergreen:
status: Fix Committed → Fix Released
no longer affects: evergreen/2.3
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers