User editor considers an empty username as valid

[Jeff Godin]

This user editor issue may be Dojo's fault:

The "required" attribute on usrname doesn't seem to be enough to trigger a yellow/invalid indicator after initial load. If you add a valid value then remove the value, the field is empty but not yellow/invalid. Adding a "not empty" check to isValid helps, but why is it required? Possibly due to interaction with required vs isValid. Testing by adding an isValid function to the barcode widget seems to confirm this.

Working branch to follow.

[Ben Shum (bshum)]

Setting status to "in progress" as Jeff works on it.

[Jeff Godin (jgodin)]

Working branch is user/jeff/fix_lp1246846_blank_username

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/jeff/fix_lp1246846_blank_username

[Ben Shum (bshum)]

Asked Melissa to test this one out as practice for learning sign-off procedures. Working for us, we'll get it in later this week.

[Melissa Ceraso (mceraso)]

I tested this and it seems to work for us. My sign off is: user/mceraso/fix_lp1246846_blank_username

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mceraso/fix_lp1246846_blank_username

[Ben Shum (bshum)]

Picked to master, rel_2_5 and rel_2_4.

Thanks Jeff for the fix and Melissa for testing.