marc_stream_importer.pl crashes with vs 0.23 of File::Temp

Bug #1246839 reported by Scott Myers
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Medium
Unassigned
2.6
Fix Released
Undecided
Unassigned
2.7
Fix Released
Undecided
Unassigned

Bug Description

File:Temp vs 0.23 changes the api which breaks marc_stream importer. Either stay on vs 0.22 or follow this guide to fix the files that use File::Temp.

http://www.dagolden.com/index.php/2109/why-the-latest-filetemp-might-surprise-you/

The only files I was able to find that use it are:

RemoteAccount.pm
Build.PL
acq_order_reader.pl
marc_stream_importer.pl

Tags: pullrequest
Ben Shum (bshum)
Changed in evergreen:
status: New → Triaged
importance: Undecided → Medium
Revision history for this message
Fredrick Parks (fparks) wrote :

Pushed a branch with marc_stream_importer.pl updated to use the File::Temp v0.23 API

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=commit;h=ba94dca0cb72819ae1507defc7b2c50fea226501

tags: added: pullrequest
Revision history for this message
Bill Erickson (berick) wrote :

New branch based on Fredrick's branch including signoff and small change:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1246839-file-temp-stream-importer

Tested on wheezy (old version file:: temp) and trusty (new version of file::temp). The (TEMPLATE => 'foo') incantation only works with new versions of file::temp, so I rolled that part of the change back from the Fredrick's patch for backwards compatibility.

Changed in evergreen:
status: Triaged → Confirmed
Revision history for this message
Galen Charlton (gmc) wrote :

Pushed to master, rel_2_7, and rel_2_6. Thanks Frederick and Bill!

Changed in evergreen:
milestone: none → 2.next
no longer affects: evergreen/2.5
Changed in evergreen:
status: Confirmed → Fix Committed
Revision history for this message
Ben Shum (bshum) wrote :

Removing 2.next top level milestone, since this was a bug fix that was repaired in an actual series maintenance release.

Changed in evergreen:
status: Fix Committed → Fix Released
milestone: 2.next → none
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.