Make sure that # can be used in auth browse

Bug #1244720 reported by Mike Rylander
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Medium
Unassigned
2.3
Fix Released
Undecided
Unassigned
2.4
Fix Released
Undecided
Unassigned

Bug Description

Because we use URLs to call the SuperCat browse API, we need to be more careful about encoding parameters. #, in particular, breaks auth browse because it's seen as a URL fragment separator by the browser and web server.

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/miker/encode-auth-browse-term

Tags: pullrequest
Revision history for this message
Yamil (ysuarez) wrote :

Mike put his small code change on our system, and the small change worked great. The change also worked great on my test server.

Here is my sign-off branch:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/ysuarez/encode-auth-browse-term_signoff

Revision history for this message
Mike Rylander (mrylander) wrote :

Thanks, Yamil. I went ahead and picked it into master, 2.4 and 2.3.

Changed in evergreen:
status: New → Fix Committed
Dan Wells (dbw2)
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.